-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSharpCodeGenerator tests #33886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca4aadb
to
695ccf9
Compare
695ccf9
to
4d394dc
Compare
stephentoub
reviewed
May 8, 2020
src/libraries/System.CodeDom/src/System/CodeDom/Compiler/ExposedTabStringIndentedTextWriter.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 8, 2020
src/libraries/System.CodeDom/src/System/CodeDom/Compiler/ExposedTabStringIndentedTextWriter.cs
Show resolved
Hide resolved
6782698
to
c0d30fa
Compare
e59241d
to
c42ceb2
Compare
af75a27
to
aa4039c
Compare
aa4039c
to
bb40f8c
Compare
d5222f2
to
f2d5329
Compare
591677c
to
bd10d57
Compare
bd10d57
to
9166462
Compare
9166462
to
22b27d0
Compare
22b27d0
to
b4e117a
Compare
buyaa-n
reviewed
Sep 17, 2020
src/libraries/System.CodeDom/src/System/CodeDom/Compiler/ExposedTabStringIndentedTextWriter.cs
Show resolved
Hide resolved
buyaa-n
reviewed
Sep 17, 2020
src/libraries/System.CodeDom/src/Microsoft/CSharp/CSharpCodeGenerator.cs
Show resolved
Hide resolved
buyaa-n
reviewed
Sep 17, 2020
src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGeneratorTests.cs
Show resolved
Hide resolved
buyaa-n
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hughbe for your contribution, this is a huge work for improving our test coverage
buyaa-n
reviewed
Sep 17, 2020
src/libraries/System.CodeDom/src/System/CodeDom/Compiler/ExposedTabStringIndentedTextWriter.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes